search

jochen-schweizer / express-prom-bundle

express middleware with standard prometheus metrics in one bundle
MIT License
310 stars 68 forks source link

excludeRoutes is missing from the TypeScript types #92

Closed RyanBard closed 3 years ago

RyanBard commented 3 years ago

While working on https://github.com/jochen-schweizer/express-prom-bundle/issues/90, I noticed that the excludeRoutes option is in the javascript code, but not in the TS types (so it can error when you try to use it in TS w/o doing some trickery -- depending on your TS settings).

RyanBard commented 3 years ago

I created https://github.com/jochen-schweizer/express-prom-bundle/pull/93 for adding excludeRoutes to the TS types.

Let me know if I should change anything, thanks!