jochym / qe-util

Set of utilities for using Quantum-Espresso with ASE and ipython notebooks.
GNU General Public License v3.0
12 stars 5 forks source link

Use env var and better search for PP names #6

Closed farhi closed 7 years ago

farhi commented 8 years ago

Hello,

I suggest the following improvement to your QE-ASE interface so that it runs smotthly with SSSP library, and environment variables. I will create a Debian package so that installation is made easy for e.g. Ubuntu, including pyspglib.

Detail of commit: init:

writers:

farhi commented 8 years ago

Hello again,

I have added smearing and electron mixing options, and fixed a conversion factor error when collecting the forces. This has been checked on e.g. the Al fcc phonon energies, as shown (expected in the 25 and 45 meV). screenshot from 2016-07-28 14 29 00

farhi commented 8 years ago

I here attach a Debian package of qe-util, built on Ubuntu 14.04/amd64. python-ase-qe-spglib_0.1.16_amd64.deb.zip

jochym commented 8 years ago

Nice. Thanks for the contribution @farhi ! One small issue though: pyspglib is now just spglib and the author prefers it to be distributed this way. Would you amend your PR?

farhi commented 8 years ago

Sure, but as I see in your code, you still have lines

which are not in sync with the current spglib. At least for the Debian package, I think it makes sense to distribute a coherent choice of versions qe-util+spglib that just work. I could also create a specific spglib package but it takes time to build these packages and maintain them.

For the PR, the code change is anyway not related to spglib, only the Deb package. BTW, all is now available at our Debain repo http;//packages.mccode.org.

Emmanuel.

jochym commented 7 years ago

Sorry for not responding quickly. The "canonical" way to import spglib now is:

try:
    import spglib
except ImportError:
    from pyspglib import spglib

This will make the code working regardless the version of the spglib in the environment.

farhi commented 7 years ago

Fully agree. I use this syntax in my own Python code as well.

jochym commented 7 years ago

Would you make the change? I will gladly merge the rest.

farhi commented 7 years ago

Just done that with the 2 above commits.