search

jockerz / Starlette-Login

User session management for Starlette
https://starlette-login.readthedocs.io
MIT License
11 stars 2 forks source link

Fix logout on remember #1

Closed eykd closed 9 months ago

eykd commented 9 months ago

logout_user(request) was not working in the face of login_user(..., remember=True). I was able to trace it to a simple typo in logout_user. This PR adds a failing test and a fix that addresses the bug.

Note: I've tested against Starlette 0.24.0 on python 3.11, which was the version current back in February at the last release of Starlette-Login. (There are some other, seemingly-unrelated test failures in test_decorator.py against 0.24.0) There are quite a few test failures against the latest Starlette (currently 0.31.1).

jockerz commented 9 months ago

Hi @eykd, I will look into this pull request very soon.

Thank you so much for your commit. :)

jockerz commented 9 months ago

There are unsuccessful checks, but that is a diffrerent issue. I will work on it