search

jocmp / capyreader

A smallish Android RSS reader
http://capyreader.com/
MIT License
175 stars 6 forks source link

Fix Time for some Feeds #353

Open TheOneImprove opened 2 months ago

TheOneImprove commented 2 months ago

Steps to Reproduce

1.Fetch the feed entries.

What is currently happening: all or some of them fetch as delivered at the current time and date.

Example Feeds: Have I been Pwned: https://feeds.feedburner.com/HaveIBeenPwnedLatestBreaches

Almodon (Arabic): https://www.almodon.com/rss

To do

jocmp commented 2 months ago

hey @TheOneImprove - thanks for the links. both of these sites are using non-standard timestamp formats. in those cases the app falls back to the "arrived at" time for each article. I'll add some code to handle these cases.

jocmp commented 2 months ago

@TheOneImprove - I have a fix up for the first feed that I'll include in the next version. Here's a demo of what that looks like:

I'm not sure I have a good fix for the other feed. That one posts published dates with future timestamps like this article: https://www.almodon.com/politics/2024/9/14/إسرائيل-تجمع-الميدانين-اللبناني-والسوري-إنزالات-الكومندوس-البداية. So the issue for that feed is not a parsing bug.

TheOneImprove commented 2 months ago

In my humble opinion, I think that it might be better to support future timestamps instead of leaving it at the current state.

Just wanted to say that you are really one of the best developers I interacted with.

Thank you for creating this amazing RSS reader.

jocmp commented 2 months ago

That sounds good to me. I'll add handling for future timestamps with #361. Thanks for the kind words!

TheOneImprove commented 2 months ago

@TheOneImprove - I have a fix up for the first feed that I'll include in the next version.

I deleted capy reader and reinstalled the new version from F-Droid, upon importing my subscriptions, I noticed some of my subscriptions come as now.

Here is examples:

Notice: I just noticed that you released 2024.09.1049 , I will check it out on F-Droid and report back here.

Thank you for your work.

TheOneImprove commented 2 months ago

The bug still exists at the latest f-droid version.

jocmp commented 2 months ago

@TheOneImprove which version number are you seeing on F-Droid? F-Droid's builds usually have a lag up to a week and the fix is available in 2024.09.1049 which I created yesterday.

The IzzyOnDroid version is usually available more quickly if you want to add an F-Droid repo. I would expect that to update to 2024.09.1049 in a day or two.

TheOneImprove commented 2 months ago

I meant the izzyondroid version, I did not know that you release also on the main F-Droid repo.

The version is 2024.09.1049.

jocmp commented 2 months ago

I'm not seeing the issue anymore on 2024.09.1049. Let me know how it compares to what you're seeing. Here's what I have.

Times are correct for https://feeds.feedburner.com/HaveIBeenPwnedLatestBreaches

For https://www.almodon.com/rss future times are saved as the "arrived at" time. This is how Feedbin handles future times and it ensures that there's a specific point-in-time to avoid showing "Just now" or a future date. The problem with future dates is that they may never arrive depending on what the server sends back.

Note how the published date is 5:04PM while the current time is 5:06PM. This is different to how it was previously where the published date was always kept in the future.

TheOneImprove commented 2 months ago

I rechecked on the latest version, the have I been pwned rss has been fixed, the following is still fetched as the current time and then cached(The time is the first time it get fetched:

Thank you for your valuable work.

jocmp commented 1 month ago

A small update

Thanks for your patience!