search

jocpae / VesselGraph

MIT License
110 stars 9 forks source link

Missing csv and Duplicate py file due to update_ogb*_master.sh #9

Closed FeynmanDNA closed 2 years ago

FeynmanDNA commented 2 years ago

Hi, as I was going through the steps in the instructions, I noticed two problems from this:

please run ./source/ogb_dataset/link_prediction/update_ogbl_master.sh and ./source/ogb_dataset/node_classification/update_ogbn_master.sh once

In the update_ogb*_master.sh files:

python3 make_master_file.py
cp master.csv ../../ogb/linkproppred/master.csv
cp make_master_file.py ../../ogb/linkproppred/make_master_file.py
  1. There are no master.csv files. Maybe it is better to mention in the README that master.csv will be generated somehow?
  2. make_master_file.py is duplicated in the source and destination folders.
jqmcginnis commented 2 years ago

@FeynmanDNA thank you very much for the question. Before we address this in the Readme, could you kindly rephrase issue 2. I am not completely sure what you are referring to. Would you propose moving the file rather than copying it?

FeynmanDNA commented 2 years ago

hi for point 2, i meant the file make_master_file.py is copied and thus duplicated, but both copies are stored and git-tracked in the source and destination folders of the cp command

jqmcginnis commented 2 years ago

Hi @FeynmanDNA,

please review the proposed changes I made in PR #14 :)

Feel free to push changes to the branch, if you stumble upon any issue!

Cheers, Julian

FeynmanDNA commented 2 years ago

@jqmcginnis Thank you very much for the fix!