search

jodastephen / jpms-module-names

Module names for the Java Module System (JPMS)
MIT License
37 stars 6 forks source link

Unexpected naming threeten-jaxb #28

Closed mkroening closed 5 years ago

mkroening commented 5 years ago

I just found the artifact io.github.threeten-jaxb:threeten-jaxb-core with the module name io.github.threetenjaxb.core to be listed under unexpected naming.

I suspect, that is because of the hyphens or because of the redundant artifact coordinates, but what exactly is the issue?

sormuras commented 5 years ago

Hi @mwkroening - thanks for raising this issue.

This is directly related to #26. For the time being, I enforce that the module name starts exactly with same characters as its Maven Group ID. This way I can be sure to have 1:1 mapping from a module name to a Maven artifact.

After adding the line io.github.threeten-jaxb=io.github.threetenjaxb into maven-group-alias.properties the module name should no longer be marked as unexpected. Next time the scanner sees a new version of io.github.threeten-jaxb:threeten-jaxb-core being published to Maven Central, it will be included in the mapping "database".

mkroening commented 5 years ago

Thanks a lot for clarification!

Shall I provide a PR?

sormuras commented 5 years ago

Done. ;-)