Fix most of the issues and test cases (see description)

joddie / pcre2el

convert between PCRE, Emacs and rx regexp syntax

GNU General Public License v3.0

242 stars 25 forks source link

Fix most of the issues and test cases (see description) #46

Closed LemonBreezes closed 2 years ago

LemonBreezes commented 2 years ago

This PR fixes #43, #41, #39, and partially addresses #40 by fixing most of the test cases. Now only 7/1093 of the test cases fail. I also made a few fixes that have not been reported as issues yet.

I believe that the remaining test cases need to be reviewed because some of them (I believe) are being executed correctly but the expected result is incorrect.

dogsleg commented 2 years ago

Cool! I can confirm that almost all issues are solved in this PR. Looks like the current maintainer is not active anymore, so I guess, @LemonBreezes, you could either try to contact them and ask about transition of maintenance in case it is OK with your plans, or just fork the package and continue its development separately.

hardaker commented 2 years ago

So it turns out that @joddie gave me write access to the repository so I was able to do the merge. Thanks for all the hard work.

dogsleg commented 2 years ago

@hardaker, thanks for your work on it! And thanks to @joddie! Since PR #42 bumping version number is merged now it would be great if you tag the current state. Thanks again!