search

joddie / pcre2el

convert between PCRE, Emacs and rx regexp syntax
GNU General Public License v3.0
242 stars 25 forks source link

Please tag new version for GNU ELPA (to include fix for #51) #54

Closed alphapapa closed 1 year ago

alphapapa commented 1 year ago

Hi,

Please tag a new release version so the version on GNU ELPA will include the fix for #51. :)

Thanks for your work on this package.

hardaker commented 1 year ago

Adam Porter @.***> writes:

Please tag a new release version so the version on GNU ELPA will include the fix for #51. :)

Thanks for your work on this package.

I think I have done the right thing and pushed a 1.9. I'm not sure how ELPA finds/pulls and requires a version. -- Wes Hardaker
My Pictures: http://photos.capturedonearth.com/

alphapapa commented 1 year ago

GNU ELPA uses only the version header in the main package file:

https://github.com/joddie/pcre2el/blob/b941ed8a96299868171fac625ecffec77de3e986/pcre2el.el#L9

So you need to increment it to 1.12 and push that to master.

FWIW, I maintain a few packages on GNU ELPA also. Since it differs from MELPA in that way, my workflow is to, after releasing a new version, push another commit that increments the version header to N+1-pre, e.g. 1.13-pre, so that further pre-release commits don't share the same version number. Then when I'm ready to release that new version, I push a commit that removes -pre, and repeat.

hardaker commented 1 year ago

Ah, I missed the version in the comments. thanks. I've pushed 1.12. I'll add a 1.13-pre tag, per your suggestion, in the future too; thanks.

alphapapa commented 1 year ago

Great, it's up at https://elpa.nongnu.org/nongnu/pcre2el.html now. Thanks!