search

jodevsa / subscene_scraper

Library to download subtitles from subscene.com
13 stars 6 forks source link

Downloading Incorrect Subtitles #2

Closed RafayGhafoor closed 6 years ago

RafayGhafoor commented 7 years ago

The Script is downloading different subtitles for movies . For eg: When Searching for Black Mass, it downloads Captivate Movie Subtitles.

Screenshot For Scraping Subtitles:- http://i.imgur.com/ehuI0Xu.png (Scraping Fine)

Screenshot For Incorrect Subtitles: If you look at the Parent Directories i.e The Movie Names and The Subtitles (*.srt) doesn't match. http://i.imgur.com/Q6dApca.png

jodevsa commented 7 years ago

hello Rafay,

We are aware of this problem, sadly this is due to "subscene.com" search engine. To get the whole picture, try manually searching for Black.Mass.2015.720p.10bit.BlueRay...;the first result is "Captive.2015.720p" and our script picks it .

RafayGhafoor commented 7 years ago

Thanks for your response jodevsa, i think this problem is solvable (But I am no JavaScript programmer so i am providing a solution below) How about looping through the results and matching the search query with the output titles. For Eg: When it is searching for Black Mass 2016 etc you can use regular expression to get the year 2016 which would be like this: '\d{4}'. It would grab 2016 from black mass and then you can remove everything after 2016 so our name remaining would be like this: From: Black.Mass.2016.HEVC.etc.Mkv To: Black.Mass.2016 (Store it in a variable for eg: SearchTerm)

and then you can do a for loop. for links in PAGE('a'): if SearchTerm in Title: getDownloadLink(fromPage)

jodevsa commented 7 years ago

surely this would work, but this would also eliminate search by release feature: meta data written after movie name is important ; searching by release name eliminates the need to sync subtitles with the movie.

Thanks,