search

jodhman / react-eyedrop

Seamlessly integrate a static typed, fully-tested color-picking React component/hook!
24 stars 11 forks source link

backgroundImage check #50

Closed iofjuupasli closed 2 years ago

iofjuupasli commented 2 years ago

window.getComputedStyle(element).backgroundImage returns string "none". So the check doesn't work as supposed

https://github.com/jodhman/react-eyedrop/blob/4a23ddec2a76ec8ef665c1f9525fc61a61938507/src/targetToCanvas/index.ts#L15

jodhman commented 2 years ago

Hello @iofjuupasli! That's very true. Forgot to take the "none" value into account. I'll push a fix and bump minor version. Will let you know as soon as it's done. 😄

jodhman commented 2 years ago

Hi again! This is now resolved in version 5.3.1. Thank you for submitting the issue here.