search

jodhman / react-eyedrop

Seamlessly integrate a static typed, fully-tested color-picking React component/hook!
24 stars 11 forks source link

onPickStart, onPickEnd for hook #55

Closed paulm17 closed 2 years ago

paulm17 commented 2 years ago

Thanks for taking the time to build this. 👍

Would be awesome if you could include the events onPickStart and onPickEnd to the hook.

I have a use case where I'm using my own UI and want to know when the picker is activated or a color has been picked or feedback when cancelPickColor has been executed.

Thanks!

jodhman commented 2 years ago

Hello @paulm17! I'm glad you've found usage for it. Version 5.4.1 comes with onPickStart, onPickEnd and onPickCancel for the hook. Let me know if anything else comes up! :blush:

paulm17 commented 2 years ago

@jodhman Sounds good. The current version is 5.3.2, when will 5.4.0 be pushed to npm?

jodhman commented 2 years ago

My apologies. Please use 5.4.1. It should be pushed to NPM just now. If it doesn't show, it could be NPM's caching, give it some minutes :woman_dancing: EDIT: Should still be installable starting from now!

paulm17 commented 2 years ago

Awesome! Can confirm 5.4.1 and the new hook events. Many thanks!