search

jodit / jodit-angular

Angular wrapper for Jodit && Hey. Due to the fact that I do not use Angular in my projects, I cannot fix plugin errors in a timely manner. If you want the plugin to develop, send PR or better become a contributor
MIT License
48 stars 35 forks source link

package is not working with typescripts noImplicitAny set to true #10

Closed atakchidi closed 6 years ago

atakchidi commented 6 years ago

When typescripts option noImplicitAny is set to true, building the app result in the following error:

ERROR in node_modules/jodit-angular/Events.d.ts(2,19): error TS7016: Could not find a declaration file for module 'jodit'. '/home/alex/projects/rwl/front/ngx-client/src/node_modules/jodit/build/jodit.min.js' implicitly has an 'any' type.

This happens because module should have proper declaration to be compatible with typescripts noImplicitAny. https://github.com/Microsoft/TypeScript/issues/15031

Please make it possible to compile with noImplicitAny options set to true, cause this feature may preserve a lot of errors, but your package is forcing people to turn this of for now.

P.S another way to avoid this is to set skipLibCheck: true introduced in ts 2.0 but it still seems not the right way to do things

ghost commented 6 years ago

+1

bergmito commented 6 years ago

+1

RenanLopes77 commented 6 years ago

+1

brunochikuji commented 6 years ago

+1

edureis commented 6 years ago

+1