jodit / jodit-angular

Angular wrapper for Jodit && Hey. Due to the fact that I do not use Angular in my projects, I cannot fix plugin errors in a timely manner. If you want the plugin to develop, send PR or better become a contributor
MIT License
48 stars 35 forks source link

Upgrade to Angular 12? #91

Closed Omzig closed 2 years ago

Omzig commented 2 years ago

I am unable to use this in an angular 12 project.

npm i jodit-angular

Errror:


npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: Solutions@1.0.0
npm ERR! Found: @angular/animations@12.2.7
npm ERR! node_modules/@angular/animations
npm ERR!   @angular/animations@"~12.2.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/animations@"^11.1.0" from jodit-angular@1.11.3
npm ERR! node_modules/jodit-angular
npm ERR!   jodit-angular@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution. ```

Is it hard to cut a new version that points to 12.2.0 animations and such?
MrElectroNick commented 2 years ago

Version upgrade and support for V12 is coming this weekend. I'll close this issues when version is released

MrElectroNick commented 2 years ago

@Omzig Please try v1.12.* It is released on npm already and let me know here if it works for you

Omzig commented 2 years ago

It hates me:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: MyApp@1.0.0
npm ERR! Found: rxjs@6.5.5
npm ERR! node_modules/rxjs
npm ERR!   rxjs@"~6.5.3" from the root project
npm ERR!   peer rxjs@"^6.5.3 || ^7.0.0" from @angular/core@12.2.13
npm ERR!   node_modules/@angular/core
npm ERR!     @angular/core@"^12.2.0" from the root project
npm ERR!     peer @angular/core@"^12.2.11" from jodit-angular@1.12.3
npm ERR!     node_modules/jodit-angular
npm ERR!       jodit-angular@"^1.12.3" from the root project
npm ERR!     6 more (@angular/animations, @angular/common, @angular/forms, ...)
npm ERR!   3 more (@angular/common, @angular/forms, @angular/router)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rxjs@"^7.4.0" from jodit-angular@1.12.3
npm ERR! node_modules/jodit-angular
npm ERR!   jodit-angular@"^1.12.3" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
"dependencies": {
        "@ag-grid-community/all-modules": "^25.3.0",
        "@ag-grid-community/angular": "^25.3.0",
        "@ag-grid-enterprise/all-modules": "^25.3.0",
        "@angular/animations": "~12.2.0",
        "@angular/cdk": "~12.2.0",
        "@angular/common": "~12.2.0",
        "@angular/compiler": "~12.2.0",
        "@angular/core": "^12.2.0",
        "@angular/forms": "~12.2.0",
        "@angular/material": "~12.2.0",
        "@angular/platform-browser": "~12.2.0",
        "@angular/platform-browser-dynamic": "~12.2.0",
        "@angular/router": "~12.2.0",
        "angular-split": "~5.0.0",
        "dompurify": "^2.3.3",
        "fast-sort": "^3.0.2",
        "font-awesome": "^4.7.0",
        "jodit": "^3.4.29",
        "jodit-angular": "^1.12.3",
        "jquery": "^3.6.0",
        "luxon": "~2.0.2",
        "ngx-bootstrap": "~7.0.0",
        "ngx-permissions": "^8.0.0",
        "noty": "^2.4.1",
        "npm": "^6.14.13",
        "postcss": "^8.2.4",
        "primeflex": "^3.1.0",
        "primeicons": "^4.1.0",
        "primeng": "^12.0.1",
        "rxjs": "~6.5.3",
        "tslib": "^2.3.0",
        "zone.js": "~0.11.4"
    },

Ran npm i jodit-angular --legacy-peer-deps to get around it for now.

MrElectroNick commented 2 years ago

Hi @Omzig. I'll try to check what can be done here this weekend

Omzig commented 2 years ago

@MrElectroNick No problem, if it has to do with the version of rxjs, the version i have selected is because of another component that says it has to be at that level. So, i am kind of stuck right now on rxjs 6.5.3 :(

Also, thank you for all your work on this control, it has saved my sanity so many times. It is so painful to use Jodit in the raw.