search

jodybrewster / react-native-linkedin-login

React Native Linkedin login
71 stars 42 forks source link

Android issue #1

Closed everhusk closed 8 years ago

everhusk commented 8 years ago

Image of error

Hey great package! I just tried this package on android by following the instructions but first it throws a compile error due to a naming collision with react native. After deleting the react native folder inside the node_modules folder it compiles, but throws the error in the picture above. Any ideas?

jodybrewster commented 8 years ago

@Everhusk Sorry didn't realize there was an issue, my bad I took to long. My initial thoughts are that the android java code has updated at some point and the javascript code didn't. I changed that init method sometime early on in the project. I'd check the javascript code in the module by going to node_modules/react-native-linkedin-login/example in the root of your project. Just make sure the javascript code in the example is close to your code. They've gotten out of sync.

In general I've migrated the JS code to ES6 and support for the significant dependencies change to RN 0.18. I may have made a mistake on versioning that breaking change not quite sure though. What version are you running of linkedin-login and the main react-native project?

everhusk commented 8 years ago

No worries! I just checked it out now and everything worked fine. Thanks for the follow up!