search

jodybrewster / react-native-linkedin-login

React Native Linkedin login
71 stars 42 forks source link

LinkedIn Config #23

Closed Misioka closed 7 years ago

Misioka commented 7 years ago

Add LinkedIn app ClientId and Secret

jodybrewster commented 7 years ago

So I've removed clientid and secret since this project is still on oauth1. You just need this so it won't break you build?

Misioka commented 7 years ago

I don't understand your question, sorry.

jodybrewster commented 7 years ago

I have recently removed the clientid and secret since its not needed. Why would you like to add it back since its not being used by Android and iOS?

Misioka commented 7 years ago

I've added them back because it's not working without them at all Can you provide some example how it works without client_id and secret?

jodybrewster commented 7 years ago

I've removed the client secret based on requests from other users. Its not secure and not recommended to keep it in your app. If you're ok with your app having the client secret I would either fork this project or keep your package.json reference hard set at the version you had before I implemented the fix. I would however recommend you update the your project by following the current readme instructions.