search

jodybrewster / react-native-linkedin-login

React Native Linkedin login
71 stars 42 forks source link

Android build failed #37

Open dmitrika opened 6 years ago

dmitrika commented 6 years ago

Hi!

Trying to setup android and can't build it. Failing with following error:

***/node_modules/react-native-linkedin-login/android/src/main/java/net/jodybrewster/linkedinlogin/RNLinkedinLoginPackage.java:29: error: method does not override or implement a method from a supertype
    @Override
    ^
1 error
:react-native-linkedin-login:compileReleaseJavaWithJavac FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-linkedin-login:compileReleaseJavaWithJavac'.

Any ideas what can be wrong?

"react-native-linkedin-login": "^1.44.1",
"react-native": "0.51.0",
dmitrika commented 6 years ago

Fixed by removing @Override, is it ok and we should commit it? I'm not really into Java world.

jodybrewster commented 6 years ago

@dmitrika I'll take a look soon

dejavughost commented 6 years ago

The root cause of this build error is the following a React Native breaking change https://github.com/facebook/react-native/issues/15232 and the solution seems to be to remove the @override line.

VentroArt commented 4 years ago

Any update? I'm asking because it's ridiculous removing this line each time when a new developer install project on his pc.