joe-bell / cva

Class Variance Authority
https://cva.style
Apache License 2.0
5.46k stars 107 forks source link

docs: Fix typo in `twMerge` example of beta installation docs #238

Closed lukemartin closed 8 months ago

lukemartin commented 8 months ago

Description

Fixes a very small, but potentially misleading typo in the twMerge example of the beta docs.

intent could seem like a special property, whereas in fact it's just an arbitrary name of a variant.

Additional context


What is the purpose of this pull request?

Before submitting the PR, please make sure you do the following

vercel[bot] commented 8 months ago

@lukemartin is attempting to deploy a commit to the cva Team on Vercel.

A member of the Team first needs to authorize it.

joe-bell commented 8 months ago

Oh shoot, nice spot!

I don't think the change you've made is correct either though – I believe it should be an object within variants?

Thanks a bunch for flagging 🙏

lukemartin commented 8 months ago

@joe-bell Oh yeah 🙈 Fixed now

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 8, 2023 9:09am
docs-beta ✅ Ready (Inspect) Visit Preview Nov 8, 2023 9:09am
joe-bell commented 8 months ago

Feel free to ignore ci / examples, can't seem to get that step working for contributors

joe-bell commented 8 months ago

Thanks again 🙏