Support generic type in intellisense

doong-jo commented 8 months ago

Description

Support generic in Intellisense

["cva\\(([^)]*)\\)", "[\"'`]([^\"'`]*).*?[\"'`]"],

👉

["cva(?:<[^>]*>)?([^)]*)", "[\"'`]([^\"'`]*).*?[\"'`]"],

AS-IS

TO-BE

Support non generic, generic both

Additional context

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[x] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Follow the Style Guide.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

vercel[bot] commented 8 months ago

@doong-jo is attempting to deploy a commit to the cva Team on Vercel.

A member of the Team first needs to authorize it.

joe-bell commented 8 months ago

Thanks for the PR, but I’m afraid cva isn’t designed to accept generic type — it’s merely intended for internal usage only! (this has been made clearer for v1)

joe-bell / cva

Support generic type in intellisense #266