joe-bell / cva

Class Variance Authority
https://cva.style
Apache License 2.0
5.71k stars 109 forks source link

Update `VariantProp` type merging logic for `Compose` interface #276

Open lunelson opened 6 months ago

lunelson commented 6 months ago

Description

This PR primarily addresses the following issue, updating the variant prop merging logic that is applied by the Compose interface, so that the union of available variant prop names is correct.

https://github.com/joe-bell/cva/issues/256

There are also some secondary simplifications of types, and application of unknown in place of any.


What is the purpose of this pull request?

Before submitting the PR, please make sure you do the following

vercel[bot] commented 6 months ago

@lunelson is attempting to deploy a commit to the cva Team on Vercel.

A member of the Team first needs to authorize it.

joe-bell commented 6 months ago

Thanks @lunelson! Bit stretched for time at the moment but I'll try to get around to testing this. Really appreciate the contribution 🙏

kaelansmith commented 2 weeks ago

@lunelson glad to see this getting pushed forward, thanks! @joe-bell are you still too busy to push this over the finish line? Any way I can help?