joe-elliott / cert-exporter

A Prometheus exporter that publishes cert expirations on disk and in Kubernetes secrets
Apache License 2.0
316 stars 87 forks source link

feat: add configmap cert check support #116

Closed lianghao208 closed 2 years ago

lianghao208 commented 2 years ago

issue: #115

I will open another PR to support webhook configuration objects.

lianghao208 commented 2 years ago

/cc @joe-elliott PTAL, thanks!

joe-elliott commented 2 years ago

Nice addition. If possible can we add a test in the test folders?

It could be similar to this but quite a bit simpler b/c you won't need cert-manager: https://github.com/joe-elliott/cert-exporter/blob/master/test/cert-manager/test.sh

Basically just start up a k8s cluster, push a configmap with a secret, validate a metric exists?

lianghao208 commented 2 years ago

Basically just start up a k8s cluster, push a configmap with a secret, validate a metric exists?

image

@joe-elliott done