Closed lianghao208 closed 2 years ago
/cc @joe-elliott PTAL, thanks!
Nice addition. If possible can we add a test in the test folders?
It could be similar to this but quite a bit simpler b/c you won't need cert-manager: https://github.com/joe-elliott/cert-exporter/blob/master/test/cert-manager/test.sh
Basically just start up a k8s cluster, push a configmap with a secret, validate a metric exists?
Basically just start up a k8s cluster, push a configmap with a secret, validate a metric exists?
@joe-elliott done
issue: #115
I will open another PR to support webhook configuration objects.