joe-elliott / cert-exporter

A Prometheus exporter that publishes cert expirations on disk and in Kubernetes secrets
Apache License 2.0
313 stars 88 forks source link

added additionalPodLabels #121

Closed tehlers320 closed 1 year ago

tehlers320 commented 1 year ago

Some orgs need labels for cost analysis or other reasons. This is usually something only done on the pods. https://github.com/joe-elliott/cert-exporter/issues/120

Before:

  template:
    metadata:
      labels:
        app.kubernetes.io/name: cert-exporter
        app.kubernetes.io/instance: release-name
        cert-exporter.io/type: deployment
      annotations:
        {}
    spec:

After (with label1/2 set to test):

   template:
    metadata:
      labels:
        app.kubernetes.io/name: cert-exporter
        app.kubernetes.io/instance: release-name
        cert-exporter.io/type: deployment
        label1: test
        label2: test
      annotations:
        {}
joe-elliott commented 1 year ago

Nice! Thanks.

tehlers320 commented 1 year ago

@joe-elliott thanks so much!

I realized i forgot to squash my commit though, sorry!

joe-elliott commented 1 year ago

No worries. Thank you!

I should really squash on merge :P