Add support for password protected certificates

joe-elliott / cert-exporter

A Prometheus exporter that publishes cert expirations on disk and in Kubernetes secrets

Apache License 2.0

313 stars 88 forks source link

Add support for password protected certificates #151

Closed Blackhawk312 closed 8 months ago

Blackhawk312 commented 9 months ago

This PR adds support for the usage of password protected certificates that are stored within Kubernetes secrets.

joe-elliott commented 8 months ago

Thanks for adding the test! Seems like there's a compilation error here:

Error: src/exporters/certRequestExporter.go:13:58: not enough arguments in call to secondsToExpiryFromCertAsBytes
    have ([]byte)
    want ([]byte, string)

Likely just need to add your password param.

(Didn't mean to close the PR. Slip of the mouse)

joe-elliott commented 8 months ago

apologies for the delay. i've been on PTO and was trying to stay away from the computer. Thanks!