search

joe-elliott / cert-exporter

A Prometheus exporter that publishes cert expirations on disk and in Kubernetes secrets
Apache License 2.0
313 stars 88 forks source link

feat: add liveness + readiness Probe to deployment #163

Closed CarstenSon closed 2 months ago

CarstenSon commented 2 months ago

feature

I usually dislike hard-coded ports and thought about creating a value containerPort or something similar for it (and referencing it in the service as well) but for now decided to use the hard-coded value as of now.

If you would like that more please let me know and I'll adjust it because otherwise it might get lost in future regressions

see 2nd commit/comment lol

closes #162

CarstenSon commented 2 months ago

Update: I hate hard-coded values so much that I just set up a containerPort in the values-file which shouldn't have any effect and most likely is never overriden but replaces the hard-coded values in service, livenessProbe, readinessProbe and the container.port itself :-)