search

joe-elliott / cert-exporter

A Prometheus exporter that publishes cert expirations on disk and in Kubernetes secrets
Apache License 2.0
313 stars 88 forks source link

Helm chart: incorrect indentations #169

Open kashtan404 opened 1 month ago

kashtan404 commented 1 month ago

There are several incorrect indentations in the helm/cert-exporter/templates/cert-manager/cert-manager.yaml which makes incorrect chart templating.

https://github.com/joe-elliott/cert-exporter/blob/d03d17cea81c5e83e5c110a909a1fd9e13bdcfd1/helm/cert-exporter/templates/cert-manager/cert-manager.yaml#L56 actual:

          resources:
            {{- toYaml .Values.certManager.resources | nindent 12 }}
          volumeMounts:
           {{- toYaml .Values.certManager.volumeMounts | nindent 12 }}

should be:

          resources:
            {{- toYaml .Values.certManager.resources | nindent 12 }}
          volumeMounts:
            {{- toYaml .Values.certManager.volumeMounts | nindent 12 }}

https://github.com/joe-elliott/cert-exporter/blob/d03d17cea81c5e83e5c110a909a1fd9e13bdcfd1/helm/cert-exporter/templates/cert-manager/cert-manager.yaml#L66 actual:

          readinessProbe:
            httpGet:
              path: /metrics
              port: {{ .Values.certManager.containerPort }}
              failureThreshold: 1
              periodSeconds: 10

should be:

          readinessProbe:
            httpGet:
              path: /metrics
              port: {{ .Values.certManager.containerPort }}
            failureThreshold: 1
            periodSeconds: 10

https://github.com/joe-elliott/cert-exporter/blob/d03d17cea81c5e83e5c110a909a1fd9e13bdcfd1/helm/cert-exporter/templates/cert-manager/cert-manager.yaml#L81 actual:

      volumes:
          {{- toYaml .Values.certManager.volumes | nindent 8 }}

should be:

      volumes:
        {{- toYaml .Values.certManager.volumes | nindent 8 }}