search

joe-elliott / cert-exporter

A Prometheus exporter that publishes cert expirations on disk and in Kubernetes secrets
Apache License 2.0
321 stars 87 forks source link

only create dashboard if create value is true #64

Closed izolight closed 3 years ago

joe-elliott commented 3 years ago

Would this change the default behavior? If someone upgraded their helm chart would this delete their dashboard?

izolight commented 3 years ago

It would only delete the dashboard if they changed the default dashboards.certManagerDashboard.create to false (which so far was a no-op). I would argue that changing this would imply wanting the dashboard not being installed.

izolight commented 3 years ago

@joe-elliott Is there anything preventing this getting merged?

joe-elliott commented 3 years ago

Apologies, let this one slip. I didn't realize that 

.Values.dashboards.certManagerDashboard.create

already existed.

joe-elliott commented 3 years ago

Thanks for the contribution! Now I have to remember how to build the helm chart :)