fix(#88): adds mountPropagation=HostToContainer to /var/lib/kubelet

joe-elliott / cert-exporter

A Prometheus exporter that publishes cert expirations on disk and in Kubernetes secrets

Apache License 2.0

316 stars 87 forks source link

fix(#88): adds mountPropagation=HostToContainer to /var/lib/kubelet #92

Closed faust64 closed 2 years ago

faust64 commented 2 years ago

As reported by @FessAectan (#88) Adds mountPropagation option to volumeMounts involving /var/lib/kubelet

joe-elliott commented 2 years ago

I'm not familiar with mountPropagation, what will this change do for cert-exporter?

faust64 commented 2 years ago

See #88. Volumes mounted within /var/lib/kubelet and shared with cert-exporter may end up stuck, when kubelet tries to unmount and release them. From the cert-exporter point of view: this won't change anything.

joe-elliott commented 2 years ago

Thanks, I'll merge, but the CI is a little wonky at the moment. So it may take me a few days to republish the helm chart. One day I will fix all this.