search

joe-elliott / cert-exporter

A Prometheus exporter that publishes cert expirations on disk and in Kubernetes secrets
Apache License 2.0
316 stars 87 forks source link

Fix dashboard ConfigMap label #94

Closed jedrivisser closed 2 years ago

jedrivisser commented 2 years ago

Currently when certManagerDashboard.create is set to true, the dashboard is not detected by the default prometheus operator.

The default config for prometheus operator and the grafana helm chart requires the label "grafana_dashboard", see:

https://github.com/grafana/helm-charts/blob/grafana-6.16.10/charts/grafana/values.yaml#L635

The other examples in the repo also has this label:

https://github.com/joe-elliott/cert-exporter/blob/v2.7.0/docs/daemonset-prom-operator.yaml#L113

joe-elliott commented 2 years ago

Thank you for the contribution!

Can you increment the helm chart version as well? That should force a rebuild.

jedrivisser commented 2 years ago

Thank you for the contribution!

Can you increment the helm chart version as well? That should force a rebuild.

Great, incremented it! :D

joe-elliott commented 2 years ago

:crossed_fingers: let's go!

joe-elliott commented 2 years ago

holy crap, i think it worked :)

CI is fixed!