Help - Adding Oracle support

joe-re / sql-language-server

SQL Language Server

MIT License

692 stars 64 forks source link

Help - Adding Oracle support #106

Open levouh opened 2 years ago

levouh commented 2 years ago

I have beyond zero experience with JS-flavor languages, but am interested in adding Oracle support. Would the best place to base my ventures off of be something like this commit (which added BigQuery)?

Any other general advice in this respect?

joe-re commented 2 years ago

@levouh Hi, thanks for your kind offer! Sure, support additional vendor is always welcome! If you need some our help, please feel free to ping me, thanks. 🙏

levouh commented 2 years ago

Well so the first question was generally around what a good commit/PR to base my changes off of would be. Do you recommend the one that added BigQuery or something else @joe-re?

joe-re commented 2 years ago

@levouh Yes, that PR would be a good example. Basically getting DB info is going to be vendor-specific implementation. database_libs (packages/server/src/database_libs) is expected to wrap this specific implementation part. So if we want to support additional vendor(in this case, for Oracle) adding database_libs/OracleClient.ts would be the first step.