Server crash

[DragonMaster14545]

Game Version, Launcher Version, Mod Version

MC 1.18.2

Forge 36.2.20

Newest beta

Problem Description

Its the same crash as I already had in Crash #11

Crash Log

https://pastebin.com/7spex8RL

[joe-vettek]

The second repair version has been uploaded. This time, a new safety measure has been added. It was a problem with pumping water before, but this time it is a problem with adding water.

[joe-vettek]

There is no rush to close this issue, you can check the situation first. Because I am busy now, I can only judge by experience.

[DragonMaster14545]

Ok thanks a lot for your quick reply

[DragonMaster14545]

https://pastebin.com/WBUqLw2A Just got this crash

[DragonMaster14545]

https://pastebin.com/ZCJy287d Happened again...

[joe-vettek]

that's a new problem

[DragonMaster14545]

Ok... Does your mod cause it?

[joe-vettek]

and it also shows that the before efforts isn't meaningless. Tomorrow I'll continue to fix the remaining bugs.

[DragonMaster14545]

Thanks a lot

[joe-vettek]

Ok... Does your mod cause it?

I think so, I'm actually surprised that create even accesses that function.

[joe-vettek]

Tomorrow I'll check all related functions and fix others may causing crash, currently all crashes are caused by the controller, which is determined by its caching mechanism.

[joe-vettek]

test for a while, no crash happens

[joe-vettek]

you can try the latest beta version

[DragonMaster14545]

Ill do thanks, btw it ran good for to days so...

[DragonMaster14545]

I got this crash in the night https://pastebin.com/tRt6TXuv

[joe-vettek]

you need use the latest 2.3.3-beta and now the version you use is 2.3.2-fix. sorry I don't say it clearly.

https://beta.curseforge.com/minecraft/mc-mods/fluid-drawers-legacy/files/4382751

[DragonMaster14545]

Ok ill try that thanks

[DragonMaster14545]

I have the latest beta version installed and just got this https://pastebin.com/iJfNUSbW Sorry for beeing so annoying

[joe-vettek]

By the way, I found another bug, which was fixed after checking. So version 2.3.5 was released. https://www.curseforge.com/minecraft/mc-mods/fluid-drawers-legacy/files/4385815

[joe-vettek]

The null pointer problem is due to the architecture, the caching mechanism requires that the drawer index collection be updated every five seconds (this is consistent with the storage drawer mod). In the old version, the update is completed by clearing the previous drawer index set and then adding the drawer index again. The new version first checks whether the old and new index sets are identical before considering whether to directly replace the entire index set. In addition, the rebuilt lock has also been updated (it is responsible for finally judging whether index updates can be performed), all adjusted to semaphores instead of boolean locks that are prone to failure during multi-threaded access.

[joe-vettek]

The final defense plan is to use try catch, but this is a more irresponsible way of writing, so I will not consider this. Thank you for your patience. It is difficult for developers to determine the cause of this hidden error

[DragonMaster14545]

Thanks for investing so much time in fixing my problem