search

joe223 / tiny-swiper

Ingenious JavaScript Carousel powered by wonderful plugins. Lightweight yet extensible. Import plugins as needed, No more, no less.
https://tiny-swiper.js.org
1.29k stars 58 forks source link

Add clickableClass and renderBullet pagination parameters #68

Closed andieelmes closed 3 years ago

andieelmes commented 3 years ago

In one of our projects we migrated from swiper to tiny-swiper and it really helped to cut down on bundle size. Thank you for the great plugin!

To make our migration complete, we needed to add clickableClass and renderBullet parameters from swiper pagination plugin: https://swiperjs.com/swiper-api#pagination. Right now we added them via a custom pagination plugin (and again, thanks for making custom plugins so easy to add), but thought maybe they would be useful in the main package.

andieelmes commented 3 years ago

I'm not sure why the build is erroring out: https://travis-ci.org/github/joe223/tiny-swiper/jobs/772704136, it happens during npm run bootstrap. Test build is fine https://travis-ci.org/github/joe223/tiny-swiper/jobs/772704137. Could you please point me in the right direction regarding this?

joe223 commented 3 years ago

@andieelmes You did a really great feature! Thanks for your feedback and precious PR！

The CI error occured with an incompatible version of NodeJS/Node-sass, and node-sass is deprecated (FYI https://sass-lang.com/blog/libsass-is-deprecated). I should use dart-sass instead of node-sass.

joe223 commented 3 years ago

@andieelmes New feature is available in v2.1.1