search

joe7575 / Minetest-Hyperloop

Transportation Mod for Minetest
Other
5 stars 6 forks source link

luacheck #13

Closed BuckarooBanzay closed 2 months ago

BuckarooBanzay commented 2 months ago

i tried to add a simple .luacheckrc to the repo and let the luacheck command run: the results don't look that bad

it might be worth from a code-quality perspective to add a few simple luacheck-constraints and enforce this in future PR's

(ping me up if you need/want/accept help :+1:)

luacheck result ``` Checking booking.lua 8 warnings booking.lua:16:7: unused variable P booking.lua:17:7: unused variable M booking.lua:20:7: unused variable NS booking.lua:36:1: line contains only whitespace booking.lua:44:1: line contains only whitespace booking.lua:58:1: line contains only whitespace booking.lua:70:1: line contains only whitespace booking.lua:77:4: line contains trailing whitespace Checking booking_node.lua 25 warnings booking_node.lua:21:7: unused variable NS booking_node.lua:23:60: trailing whitespace in a comment booking_node.lua:36:1: inconsistent indentation (SPACE followed by TAB) booking_node.lua:41:6: unused loop variable idx booking_node.lua:62:6: unused loop variable idx booking_node.lua:70:6: unused loop variable idx booking_node.lua:83:1: line contains only whitespace booking_node.lua:85:7: unused loop variable idx booking_node.lua:98:8: unused variable meta booking_node.lua:111:7: value assigned to variable naming_formspec is unused booking_node.lua:188:1: line contains only whitespace booking_node.lua:220:1: line contains only whitespace booking_node.lua:232:27: trailing whitespace in a comment booking_node.lua:258:1: line contains only whitespace booking_node.lua:266:1: line contains only whitespace booking_node.lua:267:43: unused argument itemstack booking_node.lua:267:54: unused argument pointed_thing booking_node.lua:272:35: line contains trailing whitespace booking_node.lua:296:1: line contains only whitespace booking_node.lua:304:1: line contains only whitespace booking_node.lua:305:35: unused argument placer booking_node.lua:305:43: unused argument itemstack booking_node.lua:305:54: unused argument pointed_thing booking_node.lua:312:1: line contains only whitespace booking_node.lua:313:35: line contains trailing whitespace Checking data_base.lua 11 warnings data_base.lua:15:7: unused function S data_base.lua:16:7: unused variable P data_base.lua:17:7: unused variable M data_base.lua:24:16: unused function check_data_base data_base.lua:26:15: accessing undefined variable tubelib2 data_base.lua:27:1: line contains only whitespace data_base.lua:28:41: line contains trailing whitespace data_base.lua:30:79: line contains trailing whitespace data_base.lua:33:42: line contains trailing whitespace data_base.lua:35:50: line contains trailing whitespace data_base.lua:37:4: line contains trailing whitespace Checking deco.lua 15 warnings deco.lua:18:7: unused variable NS deco.lua:24:10: setting non-standard global variable right_hand_side deco.lua:31:1: line contains only whitespace deco.lua:54:1: line contains only whitespace deco.lua:58:19: accessing undefined variable right_hand_side deco.lua:72:1: line contains only whitespace deco.lua:73:1: line contains only whitespace deco.lua:136:1: line contains only whitespace deco.lua:137:43: unused argument itemstack deco.lua:137:54: unused argument pointed_thing deco.lua:147:1: line contains only whitespace deco.lua:173:1: line contains only whitespace deco.lua:174:43: unused argument itemstack deco.lua:174:54: unused argument pointed_thing deco.lua:184:1: line contains only whitespace Checking door.lua 16 warnings door.lua:14:7: unused function SP door.lua:15:7: unused variable P door.lua:20:7: unused variable NS door.lua:23:35: unused argument node door.lua:23:50: unused argument pointed_thing door.lua:43:8: unused variable meta door.lua:119:1: line contains only whitespace door.lua:121:1: line contains only whitespace door.lua:126:1: line contains only whitespace door.lua:127:35: line contains trailing whitespace door.lua:161:1: line contains only whitespace door.lua:162:35: line contains trailing whitespace door.lua:187:1: line contains only whitespace door.lua:189:1: line contains only whitespace door.lua:194:1: line contains only whitespace door.lua:195:35: line contains trailing whitespace Checking elevator.lua 53 warnings elevator.lua:20:7: unused variable NS elevator.lua:37:15: accessing undefined variable tubelib2 elevator.lua:39:25: line contains trailing whitespace elevator.lua:41:104: line contains trailing whitespace elevator.lua:63:40: unused argument node elevator.lua:63:70: unused argument peer_in_dir elevator.lua:68:11: shadowing definition of argument node on line 63 elevator.lua:104:43: unused argument itemstack elevator.lua:111:1: line contains only whitespace elevator.lua:112:55: unused argument digger elevator.lua:115:1: line contains only whitespace elevator.lua:154:43: unused argument itemstack elevator.lua:161:1: line contains only whitespace elevator.lua:162:55: unused argument digger elevator.lua:165:1: line contains only whitespace elevator.lua:204:55: unused argument digger elevator.lua:207:1: line contains only whitespace elevator.lua:251:55: unused argument digger elevator.lua:254:1: line contains only whitespace elevator.lua:335:67: line contains trailing whitespace elevator.lua:341:1: line contains only whitespace elevator.lua:448:35: line contains trailing whitespace elevator.lua:456:43: unused argument itemstack elevator.lua:456:54: unused argument pointed_thing elevator.lua:461:1: line contains only whitespace elevator.lua:463:1: line contains only whitespace elevator.lua:466:10: shadowing upvalue formspec on line 276 elevator.lua:472:1: line contains only whitespace elevator.lua:479:15: line contains trailing whitespace elevator.lua:483:36: unused argument formname elevator.lua:524:27: unused argument node elevator.lua:524:33: unused argument puncher elevator.lua:524:42: unused argument pointed_thing elevator.lua:532:33: unused argument oldnode elevator.lua:532:42: unused argument oldmetadata elevator.lua:532:55: unused argument digger elevator.lua:562:1: line contains only whitespace elevator.lua:563:35: line contains trailing whitespace elevator.lua:587:1: line contains only whitespace elevator.lua:588:35: line contains trailing whitespace elevator.lua:610:1: line contains only whitespace elevator.lua:615:1: line contains only whitespace elevator.lua:616:32: unused argument node elevator.lua:616:38: unused argument clicker elevator.lua:616:47: unused argument itemstack elevator.lua:616:58: unused argument pointed_thing elevator.lua:626:1: line contains only whitespace elevator.lua:627:35: line contains trailing whitespace elevator.lua:649:1: line contains only whitespace elevator.lua:650:35: line contains trailing whitespace elevator.lua:671:1: line contains only whitespace elevator.lua:676:1: line contains only whitespace elevator.lua:677:35: line contains trailing whitespace Checking init.lua 2 warnings init.lua:47:42: accessing undefined variable techage init.lua:59:4: accessing undefined variable tubelib2 Checking intllib.lua 3 warnings intllib.lua:26:5: accessing undefined variable intllib intllib.lua:28:23: accessing undefined variable intllib intllib.lua:31:13: accessing undefined variable intllib Checking junction.lua 10 warnings junction.lua:14:7: unused function SP junction.lua:15:7: unused variable P junction.lua:20:7: unused variable NS junction.lua:26:69: unused argument peer_in_dir junction.lua:54:43: unused argument itemstack junction.lua:54:54: unused argument pointed_thing junction.lua:62:33: unused argument oldnode junction.lua:62:42: unused argument oldmetadata junction.lua:62:55: unused argument digger junction.lua:66:1: line contains only whitespace Checking lcd.lua 7 warnings lcd.lua:3:5: trailing whitespace in a comment lcd.lua:5:1: line contains only whitespace lcd.lua:15:7: unused variable NS lcd.lua:164:35: line contains trailing whitespace lcd.lua:173:34: unused argument placer lcd.lua:173:42: unused argument facedir lcd.lua:188:1: line contains only whitespace Checking map.lua 8 warnings map.lua:15:7: unused variable P map.lua:16:7: unused variable M map.lua:20:7: unused variable NS map.lua:33:1: line contains only whitespace map.lua:49:1: line contains only whitespace map.lua:56:7: unused loop variable dir map.lua:90:35: line contains trailing whitespace map.lua:105:35: line contains trailing whitespace Checking migrate.lua 47 warnings migrate.lua:15:1: line contains only whitespace migrate.lua:25:7: unused variable NS migrate.lua:38:28: accessing undefined variable tubelib2 migrate.lua:40:4: line contains trailing whitespace migrate.lua:45:43: line contains trailing whitespace migrate.lua:78:44: unused argument itemstack migrate.lua:98:37: shadowing upvalue argument self on line 97 migrate.lua:98:43: shadowing upvalue argument pos on line 97 migrate.lua:98:48: shadowing upvalue argument dir on line 97 migrate.lua:103:57: line contains trailing whitespace migrate.lua:104:14: accessing undefined variable tubelib2 migrate.lua:105:8: accessing undefined variable tubelib2 migrate.lua:113:1: line contains only whitespace migrate.lua:115:42: line contains trailing whitespace migrate.lua:126:4: line contains trailing whitespace migrate.lua:129:8: unused variable fpos migrate.lua:129:13: unused variable fdir migrate.lua:130:28: line contains trailing whitespace migrate.lua:138:1: line contains only whitespace migrate.lua:141:1: line contains only whitespace migrate.lua:142:8: unused variable tube_dir1 migrate.lua:143:8: unused variable tube_dir2 migrate.lua:197:37: shadowing upvalue argument pos on line 196 migrate.lua:197:42: shadowing upvalue argument dir on line 196 migrate.lua:198:15: unused variable node migrate.lua:199:21: unused variable num migrate.lua:201:7: accessing undefined variable tubelib2 migrate.lua:208:1: line contains only whitespace migrate.lua:210:37: line contains trailing whitespace migrate.lua:218:4: line contains trailing whitespace migrate.lua:223:9: unused variable npos migrate.lua:233:9: unused variable npos migrate.lua:269:30: line contains trailing whitespace migrate.lua:270:30: line contains trailing whitespace migrate.lua:271:30: line contains trailing whitespace migrate.lua:273:1: line contains only whitespace migrate.lua:275:1: line contains only whitespace migrate.lua:276:6: unused loop variable key migrate.lua:290:6: unused loop variable key migrate.lua:296:6: unused loop variable key migrate.lua:304:1: line contains only whitespace migrate.lua:310:30: line contains trailing whitespace migrate.lua:316:1: line contains only whitespace migrate.lua:317:6: unused loop variable pos migrate.lua:329:1: line contains only whitespace migrate.lua:346:27: accessing undefined variable DIR_DELIM migrate.lua:361:20: accessing undefined variable DIR_DELIM Checking network.lua 15 warnings network.lua:17:7: unused variable M network.lua:22:33: line contains trailing whitespace network.lua:24:23: line contains trailing whitespace network.lua:30:47: line contains trailing whitespace network.lua:36:36: line contains trailing whitespace network.lua:53:1: line contains only whitespace network.lua:64:57: line contains trailing whitespace network.lua:65:12: line contains trailing whitespace network.lua:67:6: unused loop variable dir network.lua:90:1: line contains only whitespace network.lua:103:17: trailing whitespace in a comment network.lua:188:1: line contains only whitespace network.lua:276:1: line contains only whitespace network.lua:280:1: line contains only whitespace network.lua:285:41: line contains trailing whitespace Checking recipes.lua 1 warning recipes.lua:18:7: unused variable NS Checking seat.lua 16 warnings seat.lua:14:7: unused function SP seat.lua:15:7: unused variable P seat.lua:20:7: unused variable NS seat.lua:23:7: unused variable Stations seat.lua:31:67: line contains trailing whitespace seat.lua:109:35: unused argument elapsed seat.lua:138:37: unused argument node seat.lua:152:1: line contains only whitespace seat.lua:158:1: line contains only whitespace seat.lua:169:1: line contains only whitespace seat.lua:171:52: line contains trailing whitespace seat.lua:185:55: line contains trailing whitespace seat.lua:210:19: line contains trailing whitespace seat.lua:232:35: line contains trailing whitespace seat.lua:233:1: line contains only whitespace seat.lua:234:34: unused argument facedir Checking station.lua 35 warnings station.lua:15:7: unused variable P station.lua:20:7: unused variable NS station.lua:41:16: trailing whitespace in a comment station.lua:54:15: trailing whitespace in a comment station.lua:72:28: trailing whitespace in a comment station.lua:75:37: line contains trailing whitespace station.lua:91:43: line contains trailing whitespace station.lua:110:4: line contains trailing whitespace station.lua:111:1: line contains only whitespace station.lua:114:18: unused variable node_name station.lua:148:46: unused argument listname station.lua:148:56: unused argument index station.lua:172:1: line contains only whitespace station.lua:192:5: line contains trailing whitespace station.lua:196:28: trailing whitespace in a comment station.lua:203:51: line contains trailing whitespace station.lua:225:5: line contains trailing whitespace station.lua:226:1: line contains only whitespace station.lua:232:19: unused variable node_name station.lua:239:50: line contains trailing whitespace station.lua:260:50: line contains trailing whitespace station.lua:265:1: line contains only whitespace station.lua:266:43: unused argument itemstack station.lua:266:54: unused argument pointed_thing station.lua:276:36: unused argument formname station.lua:283:1: line contains only whitespace station.lua:291:1: line contains only whitespace station.lua:292:33: unused argument oldnode station.lua:292:42: unused argument oldmetadata station.lua:292:55: unused argument digger station.lua:296:1: line contains only whitespace station.lua:297:35: line contains trailing whitespace station.lua:312:35: line contains trailing whitespace station.lua:327:35: line contains trailing whitespace station.lua:348:35: line contains trailing whitespace Checking tube.lua 23 warnings tube.lua:14:7: unused function S tube.lua:16:7: unused variable M tube.lua:19:7: variable S was previously defined on line 14 tube.lua:20:7: unused variable NS tube.lua:22:16: unused function station_name tube.lua:26:30: accessing undefined variable SP tube.lua:28:50: accessing undefined variable SP tube.lua:30:29: accessing undefined variable SP tube.lua:55:14: accessing undefined variable tubelib2 tube.lua:57:25: line contains trailing whitespace tube.lua:59:102: line contains trailing whitespace tube.lua:74:71: line contains trailing whitespace tube.lua:109:43: unused argument itemstack tube.lua:116:1: line contains only whitespace tube.lua:117:55: unused argument digger tube.lua:120:1: line contains only whitespace tube.lua:166:55: unused argument digger tube.lua:169:1: line contains only whitespace tube.lua:187:71: line contains trailing whitespace tube.lua:233:55: unused argument digger tube.lua:236:1: line contains only whitespace tube.lua:260:55: unused argument digger tube.lua:263:1: line contains only whitespace Checking tubecrowbar.lua 27 warnings tubecrowbar.lua:15:7: unused variable P tubecrowbar.lua:16:7: unused variable M tubecrowbar.lua:20:7: unused variable NS tubecrowbar.lua:27:15: accessing undefined variable tubelib2 tubecrowbar.lua:36:29: unused argument itemstack tubecrowbar.lua:39:61: line contains trailing whitespace tubecrowbar.lua:43:77: line contains trailing whitespace tubecrowbar.lua:55:10: shadowing definition of variable dir1 on line 39 tubecrowbar.lua:55:16: shadowing definition of variable dir2 on line 39 tubecrowbar.lua:55:22: shadowing definition of variable fpos1 on line 39 tubecrowbar.lua:55:29: shadowing definition of variable fpos2 on line 39 tubecrowbar.lua:55:36: shadowing definition of variable fdir1 on line 39 tubecrowbar.lua:55:43: shadowing definition of variable fdir2 on line 39 tubecrowbar.lua:55:50: shadowing definition of variable cnt1 on line 39 tubecrowbar.lua:55:56: shadowing definition of variable cnt2 on line 39 tubecrowbar.lua:55:62: line contains trailing whitespace tubecrowbar.lua:59:78: line contains trailing whitespace tubecrowbar.lua:73:54: line contains trailing whitespace tubecrowbar.lua:86:4: line contains trailing whitespace tubecrowbar.lua:88:28: unused argument itemstack tubecrowbar.lua:103:16: unused function dump_data_base tubecrowbar.lua:103:31: unused argument pos tubecrowbar.lua:121:41: line contains trailing whitespace tubecrowbar.lua:122:74: line contains trailing whitespace tubecrowbar.lua:130:25: unused argument param tubecrowbar.lua:131:17: accessing undefined variable worldedit tubecrowbar.lua:132:17: accessing undefined variable worldedit Checking utils.lua 6 warnings utils.lua:17:7: unused function SP utils.lua:33:9: accessing undefined variable core utils.lua:43:47: line contains trailing whitespace utils.lua:66:9: accessing undefined variable core utils.lua:70:4: line contains trailing whitespace utils.lua:85:7: unused loop variable k Checking waypoint.lua 8 warnings waypoint.lua:20:7: unused variable NS waypoint.lua:36:1: line contains only whitespace waypoint.lua:49:5: line contains trailing whitespace waypoint.lua:52:28: unused argument pos waypoint.lua:52:33: unused argument oldnode waypoint.lua:52:42: unused argument oldmetadata waypoint.lua:60:35: line contains trailing whitespace waypoint.lua:62:36: line contains trailing whitespace Checking wifi.lua 11 warnings wifi.lua:15:7: unused variable NS wifi.lua:32:35: unused argument placer wifi.lua:39:32: unused argument node wifi.lua:39:52: unused argument peer_pos wifi.lua:39:62: unused argument peer_in_dir wifi.lua:42:1: line contains only whitespace wifi.lua:43:36: unused argument formname wifi.lua:43:54: unused argument player wifi.lua:48:1: line contains only whitespace wifi.lua:49:33: unused argument oldnode wifi.lua:49:55: unused argument digger Total: 347 warnings / 0 errors in 21 files thomas@phoebe:~/.minetest/mods/hyperloop$ luacheck . Checking booking.lua 8 warnings booking.lua:16:7: unused variable P booking.lua:17:7: unused variable M booking.lua:20:7: unused variable NS booking.lua:36:1: line contains only whitespace booking.lua:44:1: line contains only whitespace booking.lua:58:1: line contains only whitespace booking.lua:70:1: line contains only whitespace booking.lua:77:4: line contains trailing whitespace Checking booking_node.lua 25 warnings booking_node.lua:21:7: unused variable NS booking_node.lua:23:60: trailing whitespace in a comment booking_node.lua:36:1: inconsistent indentation (SPACE followed by TAB) booking_node.lua:41:6: unused loop variable idx booking_node.lua:62:6: unused loop variable idx booking_node.lua:70:6: unused loop variable idx booking_node.lua:83:1: line contains only whitespace booking_node.lua:85:7: unused loop variable idx booking_node.lua:98:8: unused variable meta booking_node.lua:111:7: value assigned to variable naming_formspec is unused booking_node.lua:188:1: line contains only whitespace booking_node.lua:220:1: line contains only whitespace booking_node.lua:232:27: trailing whitespace in a comment booking_node.lua:258:1: line contains only whitespace booking_node.lua:266:1: line contains only whitespace booking_node.lua:267:43: unused argument itemstack booking_node.lua:267:54: unused argument pointed_thing booking_node.lua:272:35: line contains trailing whitespace booking_node.lua:296:1: line contains only whitespace booking_node.lua:304:1: line contains only whitespace booking_node.lua:305:35: unused argument placer booking_node.lua:305:43: unused argument itemstack booking_node.lua:305:54: unused argument pointed_thing booking_node.lua:312:1: line contains only whitespace booking_node.lua:313:35: line contains trailing whitespace Checking data_base.lua 10 warnings data_base.lua:15:7: unused function S data_base.lua:16:7: unused variable P data_base.lua:17:7: unused variable M data_base.lua:24:16: unused function check_data_base data_base.lua:27:1: line contains only whitespace data_base.lua:28:41: line contains trailing whitespace data_base.lua:30:79: line contains trailing whitespace data_base.lua:33:42: line contains trailing whitespace data_base.lua:35:50: line contains trailing whitespace data_base.lua:37:4: line contains trailing whitespace Checking deco.lua 15 warnings deco.lua:18:7: unused variable NS deco.lua:24:10: setting non-standard global variable right_hand_side deco.lua:31:1: line contains only whitespace deco.lua:54:1: line contains only whitespace deco.lua:58:19: accessing undefined variable right_hand_side deco.lua:72:1: line contains only whitespace deco.lua:73:1: line contains only whitespace deco.lua:136:1: line contains only whitespace deco.lua:137:43: unused argument itemstack deco.lua:137:54: unused argument pointed_thing deco.lua:147:1: line contains only whitespace deco.lua:173:1: line contains only whitespace deco.lua:174:43: unused argument itemstack deco.lua:174:54: unused argument pointed_thing deco.lua:184:1: line contains only whitespace Checking door.lua 16 warnings door.lua:14:7: unused function SP door.lua:15:7: unused variable P door.lua:20:7: unused variable NS door.lua:23:35: unused argument node door.lua:23:50: unused argument pointed_thing door.lua:43:8: unused variable meta door.lua:119:1: line contains only whitespace door.lua:121:1: line contains only whitespace door.lua:126:1: line contains only whitespace door.lua:127:35: line contains trailing whitespace door.lua:161:1: line contains only whitespace door.lua:162:35: line contains trailing whitespace door.lua:187:1: line contains only whitespace door.lua:189:1: line contains only whitespace door.lua:194:1: line contains only whitespace door.lua:195:35: line contains trailing whitespace Checking elevator.lua 52 warnings elevator.lua:20:7: unused variable NS elevator.lua:39:25: line contains trailing whitespace elevator.lua:41:104: line contains trailing whitespace elevator.lua:63:40: unused argument node elevator.lua:63:70: unused argument peer_in_dir elevator.lua:68:11: shadowing definition of argument node on line 63 elevator.lua:104:43: unused argument itemstack elevator.lua:111:1: line contains only whitespace elevator.lua:112:55: unused argument digger elevator.lua:115:1: line contains only whitespace elevator.lua:154:43: unused argument itemstack elevator.lua:161:1: line contains only whitespace elevator.lua:162:55: unused argument digger elevator.lua:165:1: line contains only whitespace elevator.lua:204:55: unused argument digger elevator.lua:207:1: line contains only whitespace elevator.lua:251:55: unused argument digger elevator.lua:254:1: line contains only whitespace elevator.lua:335:67: line contains trailing whitespace elevator.lua:341:1: line contains only whitespace elevator.lua:448:35: line contains trailing whitespace elevator.lua:456:43: unused argument itemstack elevator.lua:456:54: unused argument pointed_thing elevator.lua:461:1: line contains only whitespace elevator.lua:463:1: line contains only whitespace elevator.lua:466:10: shadowing upvalue formspec on line 276 elevator.lua:472:1: line contains only whitespace elevator.lua:479:15: line contains trailing whitespace elevator.lua:483:36: unused argument formname elevator.lua:524:27: unused argument node elevator.lua:524:33: unused argument puncher elevator.lua:524:42: unused argument pointed_thing elevator.lua:532:33: unused argument oldnode elevator.lua:532:42: unused argument oldmetadata elevator.lua:532:55: unused argument digger elevator.lua:562:1: line contains only whitespace elevator.lua:563:35: line contains trailing whitespace elevator.lua:587:1: line contains only whitespace elevator.lua:588:35: line contains trailing whitespace elevator.lua:610:1: line contains only whitespace elevator.lua:615:1: line contains only whitespace elevator.lua:616:32: unused argument node elevator.lua:616:38: unused argument clicker elevator.lua:616:47: unused argument itemstack elevator.lua:616:58: unused argument pointed_thing elevator.lua:626:1: line contains only whitespace elevator.lua:627:35: line contains trailing whitespace elevator.lua:649:1: line contains only whitespace elevator.lua:650:35: line contains trailing whitespace elevator.lua:671:1: line contains only whitespace elevator.lua:676:1: line contains only whitespace elevator.lua:677:35: line contains trailing whitespace Checking init.lua 1 warning init.lua:47:42: accessing undefined variable techage Checking intllib.lua 3 warnings intllib.lua:26:5: accessing undefined variable intllib intllib.lua:28:23: accessing undefined variable intllib intllib.lua:31:13: accessing undefined variable intllib Checking junction.lua 10 warnings junction.lua:14:7: unused function SP junction.lua:15:7: unused variable P junction.lua:20:7: unused variable NS junction.lua:26:69: unused argument peer_in_dir junction.lua:54:43: unused argument itemstack junction.lua:54:54: unused argument pointed_thing junction.lua:62:33: unused argument oldnode junction.lua:62:42: unused argument oldmetadata junction.lua:62:55: unused argument digger junction.lua:66:1: line contains only whitespace Checking lcd.lua 7 warnings lcd.lua:3:5: trailing whitespace in a comment lcd.lua:5:1: line contains only whitespace lcd.lua:15:7: unused variable NS lcd.lua:164:35: line contains trailing whitespace lcd.lua:173:34: unused argument placer lcd.lua:173:42: unused argument facedir lcd.lua:188:1: line contains only whitespace Checking map.lua 8 warnings map.lua:15:7: unused variable P map.lua:16:7: unused variable M map.lua:20:7: unused variable NS map.lua:33:1: line contains only whitespace map.lua:49:1: line contains only whitespace map.lua:56:7: unused loop variable dir map.lua:90:35: line contains trailing whitespace map.lua:105:35: line contains trailing whitespace Checking migrate.lua 43 warnings migrate.lua:15:1: line contains only whitespace migrate.lua:25:7: unused variable NS migrate.lua:40:4: line contains trailing whitespace migrate.lua:45:43: line contains trailing whitespace migrate.lua:78:44: unused argument itemstack migrate.lua:98:37: shadowing upvalue argument self on line 97 migrate.lua:98:43: shadowing upvalue argument pos on line 97 migrate.lua:98:48: shadowing upvalue argument dir on line 97 migrate.lua:103:57: line contains trailing whitespace migrate.lua:113:1: line contains only whitespace migrate.lua:115:42: line contains trailing whitespace migrate.lua:126:4: line contains trailing whitespace migrate.lua:129:8: unused variable fpos migrate.lua:129:13: unused variable fdir migrate.lua:130:28: line contains trailing whitespace migrate.lua:138:1: line contains only whitespace migrate.lua:141:1: line contains only whitespace migrate.lua:142:8: unused variable tube_dir1 migrate.lua:143:8: unused variable tube_dir2 migrate.lua:197:37: shadowing upvalue argument pos on line 196 migrate.lua:197:42: shadowing upvalue argument dir on line 196 migrate.lua:198:15: unused variable node migrate.lua:199:21: unused variable num migrate.lua:208:1: line contains only whitespace migrate.lua:210:37: line contains trailing whitespace migrate.lua:218:4: line contains trailing whitespace migrate.lua:223:9: unused variable npos migrate.lua:233:9: unused variable npos migrate.lua:269:30: line contains trailing whitespace migrate.lua:270:30: line contains trailing whitespace migrate.lua:271:30: line contains trailing whitespace migrate.lua:273:1: line contains only whitespace migrate.lua:275:1: line contains only whitespace migrate.lua:276:6: unused loop variable key migrate.lua:290:6: unused loop variable key migrate.lua:296:6: unused loop variable key migrate.lua:304:1: line contains only whitespace migrate.lua:310:30: line contains trailing whitespace migrate.lua:316:1: line contains only whitespace migrate.lua:317:6: unused loop variable pos migrate.lua:329:1: line contains only whitespace migrate.lua:346:27: accessing undefined variable DIR_DELIM migrate.lua:361:20: accessing undefined variable DIR_DELIM Checking network.lua 15 warnings network.lua:17:7: unused variable M network.lua:22:33: line contains trailing whitespace network.lua:24:23: line contains trailing whitespace network.lua:30:47: line contains trailing whitespace network.lua:36:36: line contains trailing whitespace network.lua:53:1: line contains only whitespace network.lua:64:57: line contains trailing whitespace network.lua:65:12: line contains trailing whitespace network.lua:67:6: unused loop variable dir network.lua:90:1: line contains only whitespace network.lua:103:17: trailing whitespace in a comment network.lua:188:1: line contains only whitespace network.lua:276:1: line contains only whitespace network.lua:280:1: line contains only whitespace network.lua:285:41: line contains trailing whitespace Checking recipes.lua 1 warning recipes.lua:18:7: unused variable NS Checking seat.lua 16 warnings seat.lua:14:7: unused function SP seat.lua:15:7: unused variable P seat.lua:20:7: unused variable NS seat.lua:23:7: unused variable Stations seat.lua:31:67: line contains trailing whitespace seat.lua:109:35: unused argument elapsed seat.lua:138:37: unused argument node seat.lua:152:1: line contains only whitespace seat.lua:158:1: line contains only whitespace seat.lua:169:1: line contains only whitespace seat.lua:171:52: line contains trailing whitespace seat.lua:185:55: line contains trailing whitespace seat.lua:210:19: line contains trailing whitespace seat.lua:232:35: line contains trailing whitespace seat.lua:233:1: line contains only whitespace seat.lua:234:34: unused argument facedir Checking station.lua 35 warnings station.lua:15:7: unused variable P station.lua:20:7: unused variable NS station.lua:41:16: trailing whitespace in a comment station.lua:54:15: trailing whitespace in a comment station.lua:72:28: trailing whitespace in a comment station.lua:75:37: line contains trailing whitespace station.lua:91:43: line contains trailing whitespace station.lua:110:4: line contains trailing whitespace station.lua:111:1: line contains only whitespace station.lua:114:18: unused variable node_name station.lua:148:46: unused argument listname station.lua:148:56: unused argument index station.lua:172:1: line contains only whitespace station.lua:192:5: line contains trailing whitespace station.lua:196:28: trailing whitespace in a comment station.lua:203:51: line contains trailing whitespace station.lua:225:5: line contains trailing whitespace station.lua:226:1: line contains only whitespace station.lua:232:19: unused variable node_name station.lua:239:50: line contains trailing whitespace station.lua:260:50: line contains trailing whitespace station.lua:265:1: line contains only whitespace station.lua:266:43: unused argument itemstack station.lua:266:54: unused argument pointed_thing station.lua:276:36: unused argument formname station.lua:283:1: line contains only whitespace station.lua:291:1: line contains only whitespace station.lua:292:33: unused argument oldnode station.lua:292:42: unused argument oldmetadata station.lua:292:55: unused argument digger station.lua:296:1: line contains only whitespace station.lua:297:35: line contains trailing whitespace station.lua:312:35: line contains trailing whitespace station.lua:327:35: line contains trailing whitespace station.lua:348:35: line contains trailing whitespace Checking tube.lua 22 warnings tube.lua:14:7: unused function S tube.lua:16:7: unused variable M tube.lua:19:7: variable S was previously defined on line 14 tube.lua:20:7: unused variable NS tube.lua:22:16: unused function station_name tube.lua:26:30: accessing undefined variable SP tube.lua:28:50: accessing undefined variable SP tube.lua:30:29: accessing undefined variable SP tube.lua:57:25: line contains trailing whitespace tube.lua:59:102: line contains trailing whitespace tube.lua:74:71: line contains trailing whitespace tube.lua:109:43: unused argument itemstack tube.lua:116:1: line contains only whitespace tube.lua:117:55: unused argument digger tube.lua:120:1: line contains only whitespace tube.lua:166:55: unused argument digger tube.lua:169:1: line contains only whitespace tube.lua:187:71: line contains trailing whitespace tube.lua:233:55: unused argument digger tube.lua:236:1: line contains only whitespace tube.lua:260:55: unused argument digger tube.lua:263:1: line contains only whitespace Checking tubecrowbar.lua 24 warnings tubecrowbar.lua:15:7: unused variable P tubecrowbar.lua:16:7: unused variable M tubecrowbar.lua:20:7: unused variable NS tubecrowbar.lua:36:29: unused argument itemstack tubecrowbar.lua:39:61: line contains trailing whitespace tubecrowbar.lua:43:77: line contains trailing whitespace tubecrowbar.lua:55:10: shadowing definition of variable dir1 on line 39 tubecrowbar.lua:55:16: shadowing definition of variable dir2 on line 39 tubecrowbar.lua:55:22: shadowing definition of variable fpos1 on line 39 tubecrowbar.lua:55:29: shadowing definition of variable fpos2 on line 39 tubecrowbar.lua:55:36: shadowing definition of variable fdir1 on line 39 tubecrowbar.lua:55:43: shadowing definition of variable fdir2 on line 39 tubecrowbar.lua:55:50: shadowing definition of variable cnt1 on line 39 tubecrowbar.lua:55:56: shadowing definition of variable cnt2 on line 39 tubecrowbar.lua:55:62: line contains trailing whitespace tubecrowbar.lua:59:78: line contains trailing whitespace tubecrowbar.lua:73:54: line contains trailing whitespace tubecrowbar.lua:86:4: line contains trailing whitespace tubecrowbar.lua:88:28: unused argument itemstack tubecrowbar.lua:103:16: unused function dump_data_base tubecrowbar.lua:103:31: unused argument pos tubecrowbar.lua:121:41: line contains trailing whitespace tubecrowbar.lua:122:74: line contains trailing whitespace tubecrowbar.lua:130:25: unused argument param Checking utils.lua 6 warnings utils.lua:17:7: unused function SP utils.lua:33:9: accessing undefined variable core utils.lua:43:47: line contains trailing whitespace utils.lua:66:9: accessing undefined variable core utils.lua:70:4: line contains trailing whitespace utils.lua:85:7: unused loop variable k Checking waypoint.lua 8 warnings waypoint.lua:20:7: unused variable NS waypoint.lua:36:1: line contains only whitespace waypoint.lua:49:5: line contains trailing whitespace waypoint.lua:52:28: unused argument pos waypoint.lua:52:33: unused argument oldnode waypoint.lua:52:42: unused argument oldmetadata waypoint.lua:60:35: line contains trailing whitespace waypoint.lua:62:36: line contains trailing whitespace Checking wifi.lua 11 warnings wifi.lua:15:7: unused variable NS wifi.lua:32:35: unused argument placer wifi.lua:39:32: unused argument node wifi.lua:39:52: unused argument peer_pos wifi.lua:39:62: unused argument peer_in_dir wifi.lua:42:1: line contains only whitespace wifi.lua:43:36: unused argument formname wifi.lua:43:54: unused argument player wifi.lua:48:1: line contains only whitespace wifi.lua:49:33: unused argument oldnode wifi.lua:49:55: unused argument digger Total: 336 warnings / 0 errors in 21 files ```
joe7575 commented 2 months ago

Thanks for the hint, is fixed