joe7575 / signs_bot

A Minetest robot controlled by signs
GNU General Public License v3.0
5 stars 7 forks source link

extend farming (and add ethereal) support #17

Closed nixnoxus closed 2 years ago

nixnoxus commented 2 years ago

This PR adds harvest and sow_seed support for further "farming" nodes (vanilla, artichoke, cabbage, sunflower, lettuce, soy_pod, blackberry, mint, parsley) by using farming.registered_plants. (commit https://github.com/joe7575/signs_bot/commit/6701f4f4af28ed418b15833dbd38bcad859e49d5) (a related bugfix https://notabug.org/TenPlus1/farming/commit/8be42d5f636923b2ec7bb01110e973dcbececd21)

Commit https://github.com/joe7575/signs_bot/commit/e49471a46735cecbddc8bf7e371dbfc80f6cbb07 adds support for "ethereal:wild_onion_plant" and "ethereal:strawberry". (With https://notabug.org/TenPlus1/ethereal/commit/d22d8a3986744c099326110d5c25cde33ac4ded1 or later)

Commit https://github.com/joe7575/signs_bot/commit/d7e264fe9cfb6567934be4a40b3abeea3c804220 Fixes a bug with "beans" and "grapes". Trellis (by that I mean "farming:beanpole" and "farming:trellis") have not been placed, but "harvested". "beans" and "grapes" are now only be seeded if suitable trellis are placed. When harvesting, the trellis are now left standing. This behavior seems to me the most compatible with existing fields. (With https://notabug.org/TenPlus1/farming/commit/3cbbb3678e8e0f24a75d28496ddbba71cb5afa32 or later. With older version the existing behavior remains)

joe7575 commented 2 years ago

Looks good, I just want to test it

nixnoxus commented 2 years ago

I had tested the customizations with Minetest 5.4.0 (and minetest_game), current mod farming and ethereal.

For this I had created a 3x3 field each for

I used signs_bot:sign_cmnd with the following program:

turn_right
harvest
sow_seed 1
move 3
exit

If there is anything else I can help with, let me know. :smile:

nixnoxus commented 2 years ago

thank you