search

joealcorn / xbox

Python wrapper around Microsoft's undocumented Xbox one APIs
http://xbox.readthedocs.org/en/latest/
MIT License
78 stars 19 forks source link

__getattr__ of DotNotationDict should raise AttributeError #2

Closed svisser closed 9 years ago

svisser commented 9 years ago

For correctness, the __getattr__ method of DotNotationDict needs to raise an AttributeError when the attribute does not exist. Otherwise, you can't write getattr(my_dict, 'attr_does_not_exit', 100) (it'll raise KeyError, it won't return to you the default value).

joealcorn commented 9 years ago

Right you are, thanks