joeattardi / picmo

JavaScript emoji picker. Any app, any framework.
https://picmojs.com
MIT License
1.19k stars 117 forks source link

Why aria-hiden = "true" is set to SVGs of category buttons #180

Closed shivam091 closed 2 years ago

shivam091 commented 2 years ago

Hi,

I enabled category buttons on emoji picker but those icons are not displaying SVGs because aria-hidden="true" is set to it.

Can you please remove that attribute if there is no specific intension behind setting it?

joeattardi commented 2 years ago

I'm not sure why the SVGs are not displaying because aria-hidden is true. Do you have some code you can share?

aria-hidden does NOT control the visibility of elements. This simply means it will not be read by a screen reader. The icons themselves are decorative only - the names of the categories are read by the screen reader via the title attribute.

A repo or codepen showing your issue would be helpful - I don't see why aria-hidden would make the SVGs not appear for you.

shivam091 commented 2 years ago

Closing this issue as some stylesheets were there in my project which was causing svg not to render.

Thank you..