search

joeattardi / picmo

JavaScript emoji picker. Any app, any framework.
https://picmojs.com
MIT License
1.19k stars 117 forks source link

Class names get conflicted #253

Closed Mizan-Rifat closed 1 year ago

Mizan-Rifat commented 1 year ago

Nice library. but the problem is you have styled it with some generic class names like content, header which creates conflict with theme classes. You should style with child selector.

joeattardi commented 1 year ago

I see the issue, I don't think a child selector will fully fix the issue though. It will fix PicMo styles leaking into your page, but external styles targeting the same classes will also leak in and affect the picker.

Let me look into this a bit, I think probably going back to prefixing the classes like I used to will solve this for now.

Development on PicMo 6 is underway which will utilize Shadow DOM so this won't be an issue then, but I can come up with a fix for version 5 for now.

joeattardi commented 1 year ago

Just published a new release, 5.7.3, that should resolve this issue. Please let me know or reopen if you still have issues!

Mizan-Rifat commented 1 year ago

Yeah, it's working but I found a new issue... https://github.com/joeattardi/picmo/issues/259