joeblack9988 / slideshow

Automatically exported from code.google.com/p/slideshow
0 stars 0 forks source link

Using destroy() no longer works with Slideshow-Mootools1.3.1 #189

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
With the new Slideshow rewrite for Mootools1.3.1, using the destroy() method 
fails with the error "array.each is not a function".  

What steps will reproduce the problem?
1.  Download Slideshow-1.3.1.zip and unzip
2.  Modify line 20 of index.html to be:
            --     new Slideshow('overlap', data, { height: 300, hu: 'images/', width: 400 });
            ++    var myShow = new Slideshow('overlap', data, { height: 300, hu: 'images/', width: 400 });
            ++    myShow.destroy('empty');
            ++    myShow = new Slideshow('overlap', data, { height: 300, hu: 'images/', width: 400 });
3.  View in Firefox 4 or Safari 5.0.4

What is the expected output? What do you see instead?
- Expected Result: slideshow to be correctly destroyed and recreated as 
outlined in http://code.google.com/p/slideshow/wiki/Slideshow#Method:_destroy
- Actual Result: Errors in console that read
Error: array.each is not a function
Line: 371

What version of the product are you using? On what operating system and
browser?
I am using this download: 
http://code.google.com/p/slideshow/downloads/detail?name=Slideshow-1.3.1.zip
Occurs in: Safari 5.0.4 and Firefox 4.0

Please provide any additional information below.
These errors did not occur in Slideshow2r199.zip

Original issue reported on code.google.com by carol...@gmail.com on 12 Apr 2011 at 5:59

GoogleCodeExporter commented 8 years ago
Operating system: Mac OS X 10.6.7

Original comment by carol...@gmail.com on 12 Apr 2011 at 6:02

GoogleCodeExporter commented 8 years ago

Original comment by aeron.gl...@gmail.com on 12 Apr 2011 at 7:27

GoogleCodeExporter commented 8 years ago
Fixed in Github

Original comment by aeron.gl...@gmail.com on 16 Apr 2011 at 2:58