joeblack9988 / slideshow

Automatically exported from code.google.com/p/slideshow
0 stars 0 forks source link

Caption broken since v1.3.1 #197

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hello,

I have a side effect between the version 1.2 and 1.3.2 about caption.
If one picture has no caption, we have two pictures without caption in one 
loop. This shifts the index of the next caption.

// Configuration
var data = {
  'keyboard.jpg':{
    caption:'(1) keyboard'
  },
  'chess.jpg':{},
  'pen.jpg':{
    caption:'(3) pen'
  },
  'phone.jpg':{
    caption:'(4) phone'
  },
};

// Actual (problem)
1. Loop 1
picture1 (keyboard.jpg) shows caption '(1) keyboard'
picture2 (chess.jpg) => no caption
picture3 (pen.jpg) => no caption 
picture4 (phone.jpg) shows caption '(3) pen'

2. Loop 2
picture1 (keyboard.jpg) shows caption '(4) phone'
picture2 (chess.jpg) shows caption '(1) keyboard'
picture3 (pen.jpg) => no caption
picture4 (phone.jpg) => no caption

3. Loop 3
picture1 (keyboard.jpg) shows caption '(3) pen'
picture2 (chess.jpg) shows caption '(4) phone'
picture3 (pen.jpg) => no caption 
picture4 (phone.jpg) => no caption

4. Loop 4
picture1 (keyboard.jpg) shows caption '(1) keyboard'
picture2 (chess.jpg) => no caption
picture3 (pen.jpg) => no caption 
picture4 (phone.jpg) shows caption '(3) pen'

// Expected
1. Loop 1
picture1 (keyboard.jpg) shows caption '(1) keyboard'
picture2 (chess.jpg) => no caption
picture3 (pen.jpg) shows caption '(3) pen'
picture4 (phone.jpg) shows caption '(4) phone'

2. Loop 2
picture1 (keyboard.jpg) shows caption '(1) keyboard'
picture2 (chess.jpg) => no caption
picture3 (pen.jpg) shows caption '(3) pen'
picture4 (phone.jpg) shows caption '(4) phone'

3. Loop 3
picture1 (keyboard.jpg) shows caption '(1) keyboard'
picture2 (chess.jpg) => no caption
picture3 (pen.jpg) shows caption '(3) pen'
picture4 (phone.jpg) shows caption '(4) phone'

4. Loop 4
picture1 (keyboard.jpg) shows caption '(1) keyboard'
picture2 (chess.jpg) => no caption
picture3 (pen.jpg) shows caption '(3) pen'
picture4 (phone.jpg) shows caption '(4) phone'

Greetings

Original issue reported on code.google.com by b.dur...@epixelic.com on 13 May 2011 at 3:33

GoogleCodeExporter commented 8 years ago
Tks for this!

Original comment by aeron.gl...@gmail.com on 13 May 2011 at 4:19

GoogleCodeExporter commented 8 years ago
This is fixed in github:
63d647335b92dee4585c3d519f0e2ddcceb0b917

Will be in the next version.

Original comment by aeron.gl...@gmail.com on 14 May 2011 at 3:21