joeblack9988 / slideshow

Automatically exported from code.google.com/p/slideshow
0 stars 0 forks source link

previous image not fading out #223

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Problem is visible only when using overlap option, and (obviously) images with 
different size (resize option to 'fit'), and not using 'fast' :  the previous 
image does not disapear during the transition.

This is not visible if image have same size, since the new image simpy fade in 
and cover (and hide) the previous one.

I made the following fix (but since I'm pretty new to javascript and 
mootools....)

--- a/rslideshowjs/slideshow.js Tue Nov 22 07:49:09 2011 +0100
+++ b/rslideshowjs/slideshow.js Tue Nov 22 22:03:24 2011 +0100
@@ -482,7 +482,7 @@
            } 
            else {
                if (this.options.overlap){
-                   img.get('morph').set(visible);
+                   img.get('morph').set(visible).start(hidden);
                    this.image.get('morph').set(hidden).start(visible);
                } 
                else {

Original issue reported on code.google.com by Danyl...@gmail.com on 23 Nov 2011 at 5:47

GoogleCodeExporter commented 8 years ago
This is more a feature than a defect. Slideshow doesn't fade out the background 
image by design - although the overlap option was added to work with different 
sized images on fading slideshows.

Original comment by aeron.gl...@gmail.com on 3 Dec 2011 at 1:50