joeblackwaslike / quart-sqlalchemy

Quart SQLAlchemy
MIT License
17 stars 4 forks source link

release 2.0 #2

Closed joeblackwaslike closed 1 year ago

joeblackwaslike commented 1 year ago

workerB

Checklist:

sourcery-ai[bot] commented 1 year ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.70%.

Quality metrics Before After Change
Complexity 6.04 ⭐ 7.63 ⭐ 1.59 👎
Method Length 63.97 🙂 60.79 ⭐ -3.18 👍
Working memory 6.52 🙂 8.01 🙂 1.49 👎
Quality 67.76% 🙂 67.06% 🙂 -0.70% 👎
Other metrics Before After Change
Lines 885 734 -151
Changed files Quality Before Quality After Quality Change
src/quart_sqlalchemy/__init__.py 98.67% ⭐ 98.67% ⭐ 0.00%
src/quart_sqlalchemy/extension.py 66.16% 🙂 66.74% 🙂 0.58% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/quart_sqlalchemy/extension.py SQLAlchemy._apply_driver_defaults 25 😞 180 😞 13 😞 33.66% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
src/quart_sqlalchemy/extension.py SQLAlchemy.init_app 15 🙂 264 ⛔ 10 😞 40.54% 😞 Try splitting into smaller methods. Extract out complex expressions
src/quart_sqlalchemy/extension.py SQLAlchemy.__init__ 4 ⭐ 138 😞 13 😞 55.05% 🙂 Try splitting into smaller methods. Extract out complex expressions
src/quart_sqlalchemy/extension.py SQLAlchemy.paginate 0 ⭐ 54 ⭐ 11 😞 73.95% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

ghost commented 1 year ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=2&src=https%3A%2F%2Fgithub.com%2Fjoeblackwaslike%2Fquart-sqlalchemy)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend