search

joeblethephilgray / svelte-playground

The goal of this project is to gain practical experience and insight working with web components and the Svelte UI framework.
0 stars 1 forks source link

Remove serve dependency #9

Closed thephilgray closed 6 years ago

thephilgray commented 6 years ago

Package not necessary for this epic. Should remove until ready to discuss deployment methods.

knoebelja commented 6 years ago

Well, I don't mind trying out now in the future. I think it's fine to leave in if you agree. We can remove it when we make a hard decision, since it was part of the template we chose. If you already think using now is a bad idea though, let's remove it.

thephilgray commented 6 years ago

@knoebelja, I don't think using now is a bad idea, but I think it makes sense to remove it as a dependency for the same reason we agreed to remove it from the README. It's safe to assume it was only included in the original template for demonstration. But since we're far from adding a deployment step, it adds extra weight and complexity. If someone were to clone the repo and attempt to use it, it might not work as expected, esp. depending on changes we make to the template. And it's not practical to manually test it each time we do make changes.

knoebelja commented 6 years ago

Okay, feel free to remove it in a PR.