search

joebo / microj

MIT License
14 stars 1 forks source link

Test failed: TEST foreign conjunction failed #12

Closed jonghough closed 9 years ago

jonghough commented 9 years ago

I ran the tests (on Linux), and got the following fail:

TEST foreign conjunction failed

adrian17 commented 9 years ago

That looks like a mistake in the test, as in other tests the parentheses are part of expected output:

tests["parentheses2"] = () => equals(toWords("((abc))"), new[] { "(", "(", "abc", ")", ")" });

But here they're not:

tests["foreign conjunction"] = () => equals(toWords("(15!:0) 'abc'"), new[] { "15", "!:", "0", "'abc'" });
joebo commented 9 years ago

Thanks, yes it is a test mistake. Good find. I will fix On Jul 11, 2015 8:17 AM, "Adrian Wielgosik" notifications@github.com wrote:

That looks like a mistake in the test, as in other tests the parentheses are part of expected output:

tests["parentheses2"] = () => equals(toWords("((abc))"), new[] { "(", "(", "abc", ")", ")" });

But here they're not:

tests["foreign conjunction"] = () => equals(toWords("(15!:0) 'abc'"), new[] { "15", "!:", "0", "'abc'" });

— Reply to this email directly or view it on GitHub https://github.com/joebo/microj/issues/12#issuecomment-120611469.

joebo commented 9 years ago

Fixed in 30b94b32a5e4a38024246151131823ab70ef0ca6