search

joeboylson / mb-portfolio

0 stars 0 forks source link

Mobile optimization #8

Open mjboylson opened 4 years ago

mjboylson commented 4 years ago

All pages need optimized for mobile. For example, on the home page, the image and information should stack. Instead of being side by side... when switched to mobile.

On the about page, much is cut off. Make it % based instead of pixels?

joeboylson commented 4 years ago

When I was developing the grid, we talked about making three set sizes for mobile, tablet, and desktop - and everything else would just be adjusted to fit into the current size.

If you wanted to make the grid percentage based, I'd need to rework a few things - for example, the background dot grid would not really define the grid anymore.

I think all the pages just need a bit of CSS work so that they fit each defined size correctly. It's just something I haven't covered yet.

joeboylson commented 4 years ago

Okay, I added a quick fix on the home page and adjusted the grid slightly (it was off-centered). The information now stacks nicely. The other pages also look pretty good (will get to the about page issue #12 )

joeboylson commented 4 years ago

@mjboylson I'll leave this one open.

Let me know what you're thoughts are on the grid. So far it's working just fine.