search

joedawson / amazon-ecs

With Laravel, search and lookup Amazon products easily.
MIT License
52 stars 26 forks source link

Added OfferFull for reading Price-History from amazon-ECS #1

Closed mrandibilbao closed 8 years ago

mrandibilbao commented 8 years ago

Hi,

i hardcoded OfferFull into search and lookup. Please make the ResponsiveGroups more dynamic, so that we can set the ResponsiveGroups in our application.

thx

joedawson commented 8 years ago

Thanks for your efforts - this PR seems to contain a lot of files I don't want included and one typo (that I've seen). But I'd be happy to add OfferAll in the next release.

mrandibilbao commented 8 years ago

thanks

joedawson commented 8 years ago

No problem, thanks for raising this.

I'll be looking to add an option to the amazon.php config file that will allow you to specify what you'd like included in the response group as an array.

So there will be a new option named something like "response_groups" then you can just add or remove anything from the array in the config.

/**
 * amazon.php
 */
'response_groups' => [
    'Images',
    'ItemAttributes',
    'OfferFull'
]

I'll likely add this at some point this weekend.

mrandibilbao commented 8 years ago

Hi Joe, I already coded a function yesterday for adding ResponseGroups. If you want, i can make a PR in the evening.

Best wishes

Joe Dawson notifications@github.com schrieb am Mi., 17. Feb. 2016 13:24:

No problem, thanks for raising this.

I'll be looking to add an option to the amazon.php config file that will allow you to specify what you'd like included in the response group as an array.

So there will be a new option named something like "response_groups" then you can just add or remove anything from the array in the config.

/* * amazon.php /'response_groups' => [ 'Images', 'ItemAttributes', 'OfferFull']

— Reply to this email directly or view it on GitHub https://github.com/JoeDawson/amazon-ecs/pull/1#issuecomment-185176803.