joedevivo / vscode-circuitpython

VSCode extension for Adafruit's CircuitPython
MIT License
119 stars 37 forks source link

build-stubs.sh needs to be updated #148

Open wmerkens opened 6 months ago

wmerkens commented 6 months ago

The build-stubs.sh script needs to be updated to the newer method of setting up the circuitpython repo download from git.

The current script would have you do the following.

    git clone --depth 1 --branch main https://github.com/adafruit/circuitpython.git

    cd circuitpython
    git submodule init
    git submodule update extmod/ulab

This will cause the stubs not to build properly due to the way certain parts are not retrieved correctly.

circuitpython has changed the way they deal with submodules, and they don't use the git submodule options.

Instead, they now use a Makefile system, so the top lines of the script need to change.

    git clone https://github.com/adafruit/circuitpython.git

    cd circuitpython
    git checkout 9.2.0  # release version of circuitpython

    # use the make commands instead of the git commands
    make fetch-all-submodules

This takes longer, but you will get correctly built stubs and boards now.

freedomlives commented 1 month ago

I notice that @joedevivo hasn't touched this repository in 9 months. Probably someone should ask to collaborate with him, or just fork and make a new version of the extension.