joedixon / laravel-translation

Translation management for your Laravel application.
MIT License
698 stars 231 forks source link

Scanner doesn't allow whitespace before/after a param #235

Closed jmiller42ce closed 2 years ago

jmiller42ce commented 2 years ago

__( 'This will also go in the JSON array' )

This pattern will not be detected by the scanner since it contains whitespace surrounding the param.

Expected behavior Scanner should detect translation function with whitespace before/after param

version: 2.0

jmiller42ce commented 2 years ago

Created PR #236 to solve.

jmiller42ce commented 2 years ago

@joedixon friendly bump- our org could use my fork but I'd really prefer to stick with your original repo to stay up-to-date. Thanks!

joedixon commented 2 years ago

Just tagged v2.1.2 with your fix. Thank you!