joedixon / laravel-translation

Translation management for your Laravel application.
MIT License
698 stars 231 forks source link

Add whitespace surrounding param to regex - solves Issue #235 #236

Closed jmiller42ce closed 2 years ago

jmiller42ce commented 2 years ago
Screen Shot 2022-07-18 at 10 50 33 AM
joedixon commented 2 years ago

Hey @jmiller42ce - thank you for this PR. Is it common for you to write your translations in the format included in you test?

__(
    'This will also go in the JSON array'
)
joedixon commented 2 years ago

Nevermind, I just saw the comment on your issue. Merged and tagged v2.1.2

jmiller42ce commented 2 years ago

Thanks @joedixon! Just for a follow-up I checked our repo for some statistics. We have 172 matches for__\(\s+, and 1328 for __\(.