search

joedolson / my-calendar

My Calendar WordPress Plugin
https://www.joedolson.com/my-calendar/
GNU General Public License v3.0
19 stars 16 forks source link

Search query is not clearing #581

Closed 0xElectric closed 7 months ago

0xElectric commented 7 months ago

Describe the bug Search query is not clearing, it is stuck to the first search query.

To Reproduce Steps to reproduce the behavior:

  1. Go to '/calendar' page
  2. Input something into 'search input', click 'search events'
  3. Replace the text in the 'search input', click 'search events' again
  4. The search query is still the same as the first search query, it is not replaced?

Expected behavior

  1. The search query should be replaced with the latest input in the 'search input'

Desktop (please complete the following information):

Additional context I think the problem is the GET request url when searching which is still stuck the first query string in the url, maybe replace the GET request url or just use POST?

joedolson commented 7 months ago

Thanks for reporting! This is actually already fixed for the next release, see: https://github.com/joedolson/my-calendar/commit/a9aead58a56b782a114c9932d5383ea8dc0ee341