joedolson / my-calendar

My Calendar WordPress Plugin
https://www.joedolson.com/my-calendar/
GNU General Public License v3.0
19 stars 16 forks source link

WPCS v3 and more! #593

Closed jdevalk closed 6 months ago

jdevalk commented 6 months ago

This pull:

And then it fixes a metric ton of WPCS warnings and errors. Most of these were auto-fixed. However, all the renamed $array, $echo, $return, $string, and $require_once variables were not. I did those manually and tried to rename them properly.

[!NOTE]
I would highly suggest turning on the WordPress-Extra ruleset too. However, doing so throws a ton of errors right now, as there's a lot of stuff happening without nonces. To add it, code like this should be added to phpcs.xml.dist.

jdevalk commented 6 months ago

@joedolson the workflow won't run without your approval, so to test it, you'll need to approve it first :)