search

joeferner / node-java

Bridge API to connect with existing Java APIs.
MIT License
1.87k stars 280 forks source link

removed dependency on lodash, removed pnpm-lock.yaml #591

Closed hulkish closed 9 months ago

hulkish commented 9 months ago

Lodash is a huge library. node-java doesn't really benefit from or actually need it.

I also saw there was a pnpm-lock.yaml & package-lock.json, so i removed pnpm-lock.yaml as it doesn't make sense, nor is it recommended to support multiple package managers.

joeferner commented 9 months ago

CI failures. We are currently using npm for CI. Perhaps instead of dropping the package-lock we drop the pnpm instead since package-lock is quite a but more familiar to most.

hulkish commented 9 months ago

CI failures. We are currently using npm for CI. Perhaps instead of dropping the package-lock we drop the pnpm instead since package-lock is quite a but more familiar to most.

Ok made that change