search

joeferner / redis-commander

Redis management tool written in node.js
http://joeferner.github.io/redis-commander/
MIT License
3.61k stars 467 forks source link

Add ingressClassName field #494

Closed albertschwarzkopf closed 1 year ago

albertschwarzkopf commented 2 years ago

Hi,

could you please add the ingressClassName field in ingress.yaml?

E.g.

{{- if and .Values.ingress.className (semverCompare ">=1.18-0" .Capabilities.KubeVersion.GitVersion) }} ingressClassName: {{ .Values.ingress.className }} {{- end }}

https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/

sseide commented 2 years ago

Hi, i will have a look into it and seems woth adding.

One remark (without rating) - adding kubernes version check within the template might irritate people running helm template to verify things they get before running helm install. Output might differ as this capabilities are faked on template run and only depend on the version helm was compile with AFAIR. Need to check it first.

sseide commented 1 year ago

hi, with addtion of the autoscaling PR the kubeVersion value is now added same as bitnami does with its charts and this can be added

sseide commented 1 year ago

@albertschwarzkopf can this be closed or some more changes needed from your side?